Move GenericServerObject to warp_server_client.#11114
Conversation
2134444 to
a816820
Compare
faa1e56 to
95879be
Compare
a816820 to
dfdd319
Compare
95879be to
29909fa
Compare
dfdd319 to
177cd5e
Compare
29909fa to
00d7ceb
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR moves the generic server-object container and supporting status/trait definitions into warp_server_client, adds app-side ServerObjectModel and GraphQL conversion adapters, and updates call sites to use the new constructor.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the reviewed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
00d7ceb to
dcd5b81
Compare
177cd5e to
44e29ef
Compare
dcd5b81 to
215b603
Compare
| @@ -0,0 +1,4 @@ | |||
| # Comment Retention Audit Notes | |||
There was a problem hiding this comment.
good catch; done. (and removed from other prs in the stack)
d772cca to
4e61d7c
Compare
4e61d7c to
3766807
Compare

Description
Moves
GenericServerObjectintowarp_server_clientso the server-response representation can be reused outside the app crate.This is the next extraction layer after the low-level type move: server-backed object containers are now portable, while app-specific model behavior remains implemented in
warp. The new upstreamserver_objectmodule owns the generic server container and supporting traits/status types, and app code adapts by implementing the minimal upstream model trait where needed.This reduces the amount of app-only infrastructure that future server-client code has to depend on before
GenericCloudObjectcan move upstream.Testing
Validated on the stack tip after Phase 3:
cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --allcargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp_server_clientcargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warpcargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --testsgit --no-pager diff --checkCo-Authored-By: Oz oz-agent@warp.dev