Skip to content

Move GenericServerObject to warp_server_client.#11114

Merged
vorporeal merged 2 commits into
masterfrom
david/move-GenericServerObject-to-warp_server_client
May 22, 2026
Merged

Move GenericServerObject to warp_server_client.#11114
vorporeal merged 2 commits into
masterfrom
david/move-GenericServerObject-to-warp_server_client

Conversation

@vorporeal
Copy link
Copy Markdown
Contributor

@vorporeal vorporeal commented May 16, 2026

Description

Moves GenericServerObject into warp_server_client so the server-response representation can be reused outside the app crate.

This is the next extraction layer after the low-level type move: server-backed object containers are now portable, while app-specific model behavior remains implemented in warp. The new upstream server_object module owns the generic server container and supporting traits/status types, and app code adapts by implementing the minimal upstream model trait where needed.

This reduces the amount of app-only infrastructure that future server-client code has to depend on before GenericCloudObject can move upstream.

Testing

Validated on the stack tip after Phase 3:

  • cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp_server_client
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests
  • git --no-pager diff --check

Co-Authored-By: Oz oz-agent@warp.dev

@cla-bot cla-bot Bot added the cla-signed label May 16, 2026
@vorporeal vorporeal force-pushed the david/move-some-types-to-warp_server_client-crate branch from 2134444 to a816820 Compare May 18, 2026 01:30
@vorporeal vorporeal force-pushed the david/move-GenericServerObject-to-warp_server_client branch from faa1e56 to 95879be Compare May 18, 2026 01:30
@vorporeal vorporeal force-pushed the david/move-some-types-to-warp_server_client-crate branch from a816820 to dfdd319 Compare May 18, 2026 14:52
@vorporeal vorporeal force-pushed the david/move-GenericServerObject-to-warp_server_client branch from 95879be to 29909fa Compare May 18, 2026 14:53
@vorporeal vorporeal force-pushed the david/move-some-types-to-warp_server_client-crate branch from dfdd319 to 177cd5e Compare May 19, 2026 18:43
@vorporeal vorporeal force-pushed the david/move-GenericServerObject-to-warp_server_client branch from 29909fa to 00d7ceb Compare May 19, 2026 18:43
@vorporeal vorporeal marked this pull request as ready for review May 20, 2026 15:25
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 20, 2026

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@vorporeal vorporeal requested a review from bnavetta May 20, 2026 15:29
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR moves the generic server-object container and supporting status/trait definitions into warp_server_client, adds app-side ServerObjectModel and GraphQL conversion adapters, and updates call sites to use the new constructor.

Concerns

  • No blocking correctness, security, or spec-alignment concerns found in the reviewed diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@vorporeal vorporeal force-pushed the david/move-GenericServerObject-to-warp_server_client branch from 00d7ceb to dcd5b81 Compare May 20, 2026 15:56
@vorporeal vorporeal force-pushed the david/move-some-types-to-warp_server_client-crate branch from 177cd5e to 44e29ef Compare May 20, 2026 15:56
Base automatically changed from david/move-some-types-to-warp_server_client-crate to master May 21, 2026 14:45
@vorporeal vorporeal force-pushed the david/move-GenericServerObject-to-warp_server_client branch from dcd5b81 to 215b603 Compare May 21, 2026 14:59
Comment thread comment-retention-audit-notes.md Outdated
@@ -0,0 +1,4 @@
# Comment Retention Audit Notes
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch; done. (and removed from other prs in the stack)

@vorporeal vorporeal force-pushed the david/move-GenericServerObject-to-warp_server_client branch from d772cca to 4e61d7c Compare May 22, 2026 18:51
@vorporeal vorporeal force-pushed the david/move-GenericServerObject-to-warp_server_client branch from 4e61d7c to 3766807 Compare May 22, 2026 18:53
@vorporeal vorporeal enabled auto-merge (squash) May 22, 2026 19:39
@vorporeal vorporeal merged commit dc408d2 into master May 22, 2026
26 checks passed
@vorporeal vorporeal deleted the david/move-GenericServerObject-to-warp_server_client branch May 22, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants