Move GenericStringModel to warp_server_client.

[vorporeal]

Description

Moves the portable generic-string scaffolding into warp_server_client as the next conservative step in the cloud-object extraction stack. Now that GenericCloudObject lives upstream, GenericStringModel, Serializer, and their portable helpers can move with it without pulling concrete model behavior out of the app crate.

This intentionally keeps the app-local pieces in warp: StringModel, CloudStringObject, CloudModelType, ModelEvent, QueueItem, ObjectClient dispatch, Drive rendering, and concrete model types. The only additional upstream hook is serializer-provided object-format metadata, which lets warp_server_client own the generic ServerObjectModel implementation without depending on app traits.

Testing

• cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp_server_client
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp
• git -C /Users/david/src/warp --no-pager diff --check

Co-Authored-By: Oz oz-agent@warp.dev

[vorporeal]

• Extract cloud object persistence logic to other crates. #11179 : 2 dependent PRs (#11378 , #11487 )
• Extract CloudObject client and models to separate crates. #11166
• Create cloud_objects crate. #11165
• Move cloud object models to separate crate. #11164
• Move GenericStringModel to warp_server_client. #11117 👈 (View in Graphite)
• Move GenericCloudObject to warp_server_client. #11115
• Move GenericServerObject to warp_server_client. #11114
• Move some types to the warp_server_client crate. #11113
• Delete unused new_from_server_update function. #11112
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves the portable GenericStringModel and Serializer scaffolding into warp_server_client, re-exports it for app-local cloud object code, and keeps concrete app behavior in warp. The added serializer-provided object-format hook preserves the generic ServerObjectModel implementation without pulling app traits upstream.

Concerns

• No blocking concerns found.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves the portable GenericStringModel and Serializer scaffolding into warp_server_client, re-exports them back through the app module, and keeps the app-specific cloud object behavior in warp. The new serializer-provided object-format hook preserves the existing generic string object type mapping for JSON-backed models.

Concerns

• No blocking correctness, spec-alignment, or security concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz