Move GenericCloudObject to warp_server_client.

[vorporeal]

Description

Moves GenericCloudObject into warp_server_client while keeping app-local cloud object behavior in warp.

The upstream type now owns the portable data/container behavior: model accessors, constructors, server update/conflict handling, and portable upsert params. The app crate continues to own CloudObject, CloudModelType, persistence events, queue behavior, UI/Drive integration, and other runtime-specific logic.

This also adds app-local lookup extension traits so type aliases can keep readable calls like CloudAmbientAgentEnvironment::get_all(ctx), CloudScheduledAmbientAgent::get_by_id(...), and CloudMCPServer::get_by_uuid(...) without duplicating helper functions or making the upstream crate depend on AppContext/CloudModel.

Testing

Validated on the stack tip after Phase 3:

• cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp_server_client
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests
• git --no-pager diff --check

Co-Authored-By: Oz oz-agent@warp.dev

[vorporeal]

• Extract cloud object persistence logic to other crates. #11179 : 2 dependent PRs (#11378 , #11487 )
• Extract CloudObject client and models to separate crates. #11166
• Create cloud_objects crate. #11165
• Move cloud object models to separate crate. #11164
• Move GenericStringModel to warp_server_client. #11117
• Move GenericCloudObject to warp_server_client. #11115 👈 (View in Graphite)
• Move GenericServerObject to warp_server_client. #11114
• Move some types to the warp_server_client crate. #11113
• Delete unused new_from_server_update function. #11112
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves GenericCloudObject and portable upsert parameter handling into warp_server_client, while keeping app-local lookup helpers, persistence events, queue behavior, and UI integrations in the app crate. The changed call sites appear to preserve the previous server update, conflict, lookup, and persistence behavior.

Concerns

• No blocking correctness, spec-alignment, or security concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[bnavetta]

Nice!

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves the portable GenericCloudObject implementation and upsert parameter payload into warp_server_client, leaving app-specific lookup helpers, persistence events, and runtime behavior in the app crate. It updates the cloud object persistence/event APIs and call sites to pass portable upsert parameters, and adds app-local lookup traits for existing type-alias ergonomics.

Concerns

No blocking correctness, security, or spec-alignment concerns were found in the annotated diff. No approved spec context was available for deeper spec validation.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz