Move some types to the warp_server_client crate.

[vorporeal]

Description

Moves the low-level cloud object, drive, ID, and server request/response types that are shared with server-client code into warp_server_client.

This creates a stable boundary for later extracting the generic server/cloud object containers without pulling app-local CloudModel, UI, or runtime behavior into the client crate. Existing app import paths continue to work through re-exports where practical.

Key pieces moved or introduced here:

• Cloud object identity and format types such as ObjectType, ObjectIdType, GenericStringObjectFormat, JsonObjectType, and generic string uniqueness metadata.
• Sync and server ID support such as ClientId, SyncId, ObjectUid, and sqlite hash helpers.
• Drive object addressing types such as CloudObjectTypeAndId and open-object args/settings.
• Portable create/update payload and result types under warp_server_client::cloud_object.

Testing

Validated on the stack tip after Phase 3:

• cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp_server_client
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp
• cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests
• git --no-pager diff --check

Co-Authored-By: Oz oz-agent@warp.dev

[vorporeal]

• Extract cloud object persistence logic to other crates. #11179 : 2 dependent PRs (#11378 , #11487 )
• Extract CloudObject client and models to separate crates. #11166
• Create cloud_objects crate. #11165
• Move cloud object models to separate crate. #11164
• Move GenericStringModel to warp_server_client. #11117
• Move GenericCloudObject to warp_server_client. #11115
• Move GenericServerObject to warp_server_client. #11114
• Move some types to the warp_server_client crate. #11113 👈 (View in Graphite)
• Delete unused new_from_server_update function. #11112
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves shared cloud object, drive addressing, ID, and create/update request/result types into warp_server_client, with app-level re-exports preserving existing import paths where practical. It also replaces conversion impls that would violate orphan-rule constraints after the move with local helper functions.

Concerns

• No blocking correctness, security, or spec-alignment concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[bnavetta]

Guessing this was in the original code, but we can't derive Clone on UpdatedObjectInput?

[vorporeal]

yeah, looks like this was in the original code. we probably can; i can shove another PR onto this stack to make that change. (i think this code moves again in a future PR, so would rather not make the change here and need to deal with a conflict, if any.)